Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Count removal of instance config override as one changed field on instance edit #921

Merged
merged 1 commit into from
Sep 23, 2024

Conversation

edlerd
Copy link
Collaborator

@edlerd edlerd commented Sep 23, 2024

Done

  • Count removal of instance config override as one changed field on instance edit

QA

  1. Run the LXD-UI:
  2. Perform the following QA steps:
    • create instance and profile with an overridden primitve field (i.e. security > Protect deletion)
    • save instance/profile
    • edit instance/profile only remove the primitive field override
    • ensure the save button is enabled and lists one pending change

@webteam-app
Copy link

@mas-who
Copy link
Collaborator

mas-who commented Sep 23, 2024

Thanks for the fix, LGTM 👍

@edlerd edlerd merged commit c1b7800 into canonical:main Sep 23, 2024
12 checks passed
github-actions bot pushed a commit that referenced this pull request Sep 23, 2024
@edlerd edlerd deleted the count-instance-remove-override branch October 18, 2024 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants