Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove workaround for extracting instance name from snapshot operation [WD-14541] #918

Merged
merged 1 commit into from
Sep 24, 2024

Conversation

mas-who
Copy link
Collaborator

@mas-who mas-who commented Sep 23, 2024

Done

  • previously, an operation for creating an instance from a snapshot would include the snapshot name in the instances resource field within the operation response metadata. We had to include a workaround to filter out the snapshots in order to extract the instance name.
  • with this upstream PR merged, we can now remove the workaround

QA

  1. Run the LXD-UI:
  2. Perform the following QA steps:
    • Create an instance from a snapshot
    • Make sure that the operation shows the new instance name

@webteam-app
Copy link

@mas-who
Copy link
Collaborator Author

mas-who commented Sep 23, 2024

@edlerd I tried refreshing my lxd snap on latest/edge channel and I see the commit isn't pointing at the latest on main branch yet. It could be getting released to the snap channel still, so we may have to wait a bit before testing again.

@mas-who mas-who force-pushed the update-operation-instance-name branch from 3878915 to 5856fb4 Compare September 23, 2024 14:59
Copy link
Collaborator

@edlerd edlerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mas-who mas-who merged commit 805f4f7 into canonical:main Sep 24, 2024
12 checks passed
github-actions bot pushed a commit that referenced this pull request Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants