Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show help text on instance location #915

Merged
merged 1 commit into from
Sep 20, 2024

Conversation

edlerd
Copy link
Collaborator

@edlerd edlerd commented Sep 19, 2024

Done

  • Show help text on instance location to direct user how to start a migration
  • Improve labels in instance configuration
  • User "cluster member" as label instead of "location" consistently
  • fix cluster group selector styling

QA

  1. Run the LXD-UI:
  2. Perform the following QA steps:
    • Check the instance location field in the instance configuration on the instance detail page. Ensure the help text works to guide the user.

@webteam-app
Copy link

@edlerd edlerd force-pushed the add-instance-location-help branch 3 times, most recently from f42e485 to 488356b Compare September 19, 2024 16:22
@mas-who
Copy link
Collaborator

mas-who commented Sep 19, 2024

QA looks good, small copy suggestion.

@edlerd edlerd force-pushed the add-instance-location-help branch from 488356b to 57fffe7 Compare September 19, 2024 19:44
@edlerd edlerd force-pushed the add-instance-location-help branch from 57fffe7 to e68a6c2 Compare September 19, 2024 19:48
@edlerd edlerd requested a review from mas-who September 19, 2024 19:49
@mas-who
Copy link
Collaborator

mas-who commented Sep 20, 2024

LGTM, thanks for the changes 👍

@edlerd edlerd merged commit a909c5b into canonical:main Sep 20, 2024
12 checks passed
github-actions bot pushed a commit that referenced this pull request Sep 20, 2024
@edlerd edlerd deleted the add-instance-location-help branch October 18, 2024 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants