-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: custom single option select component [WD-10960] #912
Conversation
ccf9514
to
7ff3f5f
Compare
@edlerd I updated the implementation for Lastly, I still need to fix the permission e2e tests, but thought we should have a discussion around about the above topic first since these tests could be affected. |
Interesting idea, but we should not use a chip as non-interactive element as per the design guidelines. They should be interactive, here we need a component that is informational, not interactive. |
Aah thanks for the tip! This is currently just a demonstration for what we can do with the new select component 🙂 Not sure if we should update how the option labels are presented as part of this PR though since it might broaden the scope a bit? |
56a4c5c
to
24f5aa0
Compare
c5bff4d
to
d644827
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The select works nicely and looks great!
One QA issue:
- when having many options with some being truncated, then searching for options that have short description, the dropdown width decreases for me
Also a couple of other ideas below.
This comment was marked as resolved.
This comment was marked as resolved.
e9cbfd0
to
cd383b3
Compare
This comment was marked as resolved.
This comment was marked as resolved.
cd383b3
to
b6614e0
Compare
This comment was marked as resolved.
This comment was marked as resolved.
b6614e0
to
a0d2101
Compare
This comment was marked as resolved.
This comment was marked as resolved.
cbdad01
to
921583e
Compare
This comment was marked as resolved.
This comment was marked as resolved.
4c139d7
to
0b17478
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
QA looks mostly good now, found one more issue below.
Several comments for the code.
300ab1a
to
182ab0b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Found one more issue on QA, code also seems all right, just one naming issue that confused me.
c969494
to
513ce03
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
QA and code LGTM, one idea to simplify a bit more.
Signed-off-by: Mason Hu <[email protected]>
513ce03
to
2280b22
Compare
Done
QA