Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

On permission select, show image names with image type (vm or container) #908

Merged
merged 1 commit into from
Sep 17, 2024

Conversation

edlerd
Copy link
Collaborator

@edlerd edlerd commented Sep 17, 2024

Done

  • On permission select, show image names with image type (vm or container)

QA

  1. Run the LXD-UI:
  2. Perform the following QA steps:
    • have a cached image locally available for vm and contianer
    • go to permissions > group > create group > add permissions > image
    • ensure the two images (for vm and container) are visible in the selector

@webteam-app
Copy link

src/util/permissions.tsx Outdated Show resolved Hide resolved
@edlerd edlerd force-pushed the fix-permission-image branch from aab6c5d to 7d7840d Compare September 17, 2024 15:47
@mas-who
Copy link
Collaborator

mas-who commented Sep 17, 2024

LGTM

@mas-who mas-who merged commit 018d6af into canonical:main Sep 17, 2024
12 checks passed
github-actions bot pushed a commit that referenced this pull request Sep 17, 2024
@edlerd edlerd deleted the fix-permission-image branch October 18, 2024 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants