Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(idp-group) deselect idp group after deletion, deselct idp group on cancel of edit panel #902

Merged
merged 1 commit into from
Sep 16, 2024

Conversation

edlerd
Copy link
Collaborator

@edlerd edlerd commented Sep 16, 2024

Done

  • this fixes two issues with idp group selection
    1. on edit idp group and cancel, we should unselect the group
    1. on select idp group, then delete the single row, we should remove the deleted group from the selection.

QA

  1. Run the LXD-UI:
  2. Perform the following QA steps:
    • edit idp group, in the panel click cancel, ensure the group is unselected
    • select and idp group, delete it from the row (not bulk delete), ensure the group gets unselected
    • bulk delete idp groups, ensure they get unselected.

@webteam-app
Copy link

@mas-who
Copy link
Collaborator

mas-who commented Sep 16, 2024

Thanks for the fixes, LGTM 👍

@edlerd edlerd merged commit a1b45cf into canonical:main Sep 16, 2024
12 checks passed
github-actions bot pushed a commit that referenced this pull request Sep 16, 2024
@edlerd edlerd deleted the fix-idp-group branch October 18, 2024 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants