Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow forked PRs to access repo secrets #894

Merged
merged 1 commit into from
Sep 13, 2024
Merged

fix: allow forked PRs to access repo secrets #894

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 6 additions & 7 deletions .github/workflows/coverage.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,16 +6,15 @@ on:

jobs:
e2e-coverage:
environment: ci-end-to-end
name: e2e-test-coverage
runs-on: ubuntu-latest
env:
LXD_OIDC_CLIENT_ID: ${{ secrets.LXD_OIDC_CLIENT_ID }}
LXD_OIDC_ISSUER: ${{ secrets.LXD_OIDC_ISSUER }}
LXD_OIDC_AUDIENCE: ${{ secrets.LXD_OIDC_AUDIENCE }}
LXD_OIDC_USER: ${{ secrets.LXD_OIDC_USER }}
LXD_OIDC_PASSWORD: ${{ secrets.LXD_OIDC_PASSWORD }}
LXD_OIDC_GROUPS_CLAIM: ${{ secrets.LXD_OIDC_GROUPS_CLAIM }}
LXD_OIDC_CLIENT_ID: "gxj297yfAjmklILK5WqPWDSbtVBAeSQm"
LXD_OIDC_ISSUER: "https://dev-xjrvvfikbsv4jxn7.us.auth0.com/"
LXD_OIDC_AUDIENCE: "https://dev-xjrvvfikbsv4jxn7.us.auth0.com/api/v2/"
LXD_OIDC_USER: "[email protected]"
LXD_OIDC_PASSWORD: "lxd-ui-e2e-password"
LXD_OIDC_GROUPS_CLAIM: "lxd-idp-groups"
steps:
- uses: actions/checkout@v4

Expand Down
16 changes: 6 additions & 10 deletions .github/workflows/pr.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@ jobs:

lint-scss:
runs-on: ubuntu-latest

steps:
- uses: actions/checkout@v4

Expand All @@ -38,7 +37,6 @@ jobs:

lint-js:
runs-on: ubuntu-latest

steps:
- uses: actions/checkout@v4

Expand All @@ -50,7 +48,6 @@ jobs:

check-inclusive-naming:
runs-on: ubuntu-latest

steps:
- name: Checkout
uses: actions/checkout@v4
Expand All @@ -63,7 +60,6 @@ jobs:
fail-on-error: true

browser-e2e-test:
environment: ci-end-to-end
name: e2e-tests
runs-on: ubuntu-latest
strategy:
Expand All @@ -74,12 +70,12 @@ jobs:
outputs:
job_status: ${{job.status}}
env:
LXD_OIDC_CLIENT_ID: ${{ secrets.LXD_OIDC_CLIENT_ID }}
LXD_OIDC_ISSUER: ${{ secrets.LXD_OIDC_ISSUER }}
LXD_OIDC_AUDIENCE: ${{ secrets.LXD_OIDC_AUDIENCE }}
LXD_OIDC_USER: ${{ secrets.LXD_OIDC_USER }}
LXD_OIDC_PASSWORD: ${{ secrets.LXD_OIDC_PASSWORD }}
LXD_OIDC_GROUPS_CLAIM: ${{ secrets.LXD_OIDC_GROUPS_CLAIM }}
LXD_OIDC_CLIENT_ID: "gxj297yfAjmklILK5WqPWDSbtVBAeSQm"
LXD_OIDC_ISSUER: "https://dev-xjrvvfikbsv4jxn7.us.auth0.com/"
LXD_OIDC_AUDIENCE: "https://dev-xjrvvfikbsv4jxn7.us.auth0.com/api/v2/"
LXD_OIDC_USER: "[email protected]"
LXD_OIDC_PASSWORD: "lxd-ui-e2e-password"
LXD_OIDC_GROUPS_CLAIM: "lxd-idp-groups"
steps:
- uses: actions/checkout@v4

Expand Down
Loading