Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

delay clearing instance cache when an instance state change fails #882

Merged

Conversation

edlerd
Copy link
Collaborator

@edlerd edlerd commented Sep 5, 2024

Done

QA

  1. Run the LXD-UI:
  2. Perform the following QA steps:
    • create an instance, set "Resource Limits" > "Max number of processes" to 1.
    • Start the instnance
    • Ensure the instance is reported as stopped, not as running on the startup error.

…ange fails to avoid reporting wrong intermediate instance status as returned by the api shortly after a state change failure

Signed-off-by: David Edler <[email protected]>
@webteam-app
Copy link

Copy link
Contributor

@Kxiru Kxiru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for implementing this :)

@edlerd edlerd merged commit 89fe54a into canonical:main Sep 6, 2024
12 checks passed
@edlerd edlerd deleted the delay-instance-refetch-on-state-change-failure branch September 6, 2024 12:46
github-actions bot pushed a commit that referenced this pull request Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants