Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

simplify auto expanding text area component #877

Merged
merged 1 commit into from
Sep 3, 2024
Merged

simplify auto expanding text area component #877

merged 1 commit into from
Sep 3, 2024

Conversation

edlerd
Copy link
Collaborator

@edlerd edlerd commented Sep 3, 2024

Done

  • simplify auto expanding text area component

QA

  1. Run the LXD-UI:
  2. Perform the following QA steps:
    • check text areas are rendered well

@webteam-app
Copy link

Demo

Jenkins

demos.haus

Kxiru
Kxiru approved these changes Sep 3, 2024
View reviewed changes
Copy link
Contributor

@Kxiru Kxiru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, and still responsive. Thanks a bunch :)

@edlerd edlerd merged commit 810d436 into canonical:main Sep 3, 2024
12 checks passed
github-actions bot pushed a commit that referenced this pull request Sep 3, 2024
workflow: remove all reports for PR #877
4ea6472
@edlerd edlerd deleted the simplify-textarea branch September 4, 2024 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kxiru Kxiru Kxiru approved these changes

Assignees
No one assigned
Labels
Review: Code needed Review: QA needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@edlerd @webteam-app @Kxiru