Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add export of instances WD-13701 #872

Merged
merged 1 commit into from
Sep 2, 2024
Merged

Conversation

edlerd
Copy link
Collaborator

@edlerd edlerd commented Aug 30, 2024

Done

  • Add export of instances

Fixes WD-13701

QA

  1. Run the LXD-UI:
  2. Perform the following QA steps:
    • export an instance from the instance detail page

@webteam-app
Copy link

Copy link
Contributor

@Kxiru Kxiru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Heya!
Thanks for this implementation. Exporting the image works well for me. Just one question though, for instances that are running, I find that the Export image button is not disabled. Should one be able to create a backup of an instance even when it is running?

@edlerd
Copy link
Collaborator Author

edlerd commented Sep 2, 2024

Heya! Thanks for this implementation. Exporting the image works well for me. Just one question though, for instances that are running, I find that the Export image button is not disabled. Should one be able to create a backup of an instance even when it is running?

Yes, we can export a running instance. That works in thelxc export cli, as well as in the api we are using here.

@edlerd edlerd requested a review from Kxiru September 2, 2024 15:38
Copy link
Contributor

@Kxiru Kxiru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you for the extra feature and for clarifying whether to export during a running instance 👍 .

@edlerd edlerd merged commit dc3448f into canonical:main Sep 2, 2024
12 checks passed
github-actions bot pushed a commit that referenced this pull request Sep 2, 2024
@edlerd edlerd deleted the instance-export branch September 4, 2024 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants