fix: remove bulk instance migration feature due to server loading concerns #869
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Demo
Jenkins 
demos.haus 
Kxiru
reviewed
Aug 29, 2024
edlerd
reviewed
Aug 29, 2024
mas-who
force-pushed
the
remove-bulk-instance-migration
branch
2 times, most recently
from
8271003 to
25398b0
Compare
Yeah I'm also not a huge fan of this change, but I think overloading the server is a valid point. If you don't want to merge this one, maybe when I get back we can look into processing batches of requests instead. In the interim, I've done some more cleaning up, removed all bulk migration related logic and also adjusted the modal component to process a single instance only. |
mas-who
force-pushed
the
remove-bulk-instance-migration
branch
from
25398b0 to
f39b31e
Compare
…cerns Signed-off-by: Mason Hu <[email protected]>
mas-who
force-pushed
the
remove-bulk-instance-migration
branch
from
f39b31e to
dcb933c
Compare
Kxiru
pushed a commit
to Kxiru/lxd-ui
that referenced
this pull request
Sep 9, 2024
…cerns (canonical#869) - From the discussion with lxd team, there are concerns about potentially overloading the server if bulk migration is performed on a large number of instances. For now, we will remove the feature and wait for the team to add background task scheduling capability so we can do bulk actions in the UI without issues.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Done
Fixes [list issues/bugs if needed]
QA
Migratebutton is no longer visible when selecting multiple instances on the instance list page.