Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: infinite api call loop when duplicating instance #859

Merged
merged 1 commit into from
Aug 26, 2024

Conversation

mas-who
Copy link
Collaborator

@mas-who mas-who commented Aug 26, 2024

Done

  • The duplicate instance form currently gets stuck in a infinite loop of api calls as the query cache is being invalidated in getDuplicatedInstanceName. This PR resolves the issue.

QA

  1. Run the LXD-UI:
  2. Perform the following QA steps:
    • Check network calls when the duplicate instance form is open.

@webteam-app
Copy link

Copy link
Collaborator

@edlerd edlerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mas-who mas-who merged commit 5f2226f into canonical:main Aug 26, 2024
12 checks passed
github-actions bot pushed a commit that referenced this pull request Aug 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants