feat: Add create instance from snapshot feature [WD-14411]

[mas-who]

Done

• Add duplicate snapshot feature

Notes

• Currently using the copy vanilla icon for the duplicate snapshot button
• Removed the allowInconsistent and instanceOnly options. These are not relevant for snapshot duplication.
• Stateful copy is only relevant for stateful snapshots
• For a stateful copy of a snapshot, the instance name must remain the same. This means the instance cannot be created in the same project. Tested this in the CLI, it's the same behaviour (see code ref). Therefore, I added some additional form validation logic. If the Copy stateful option is checked, then validation is performed on instance name (must be the same as the original instance name) and target project (must be a different project to the source instance project).
  

QA

1. Run the LXD-UI:
   • On the demo server via the link posted by @webteam-app below. This is only available for PRs created by collaborators of the repo. Ask @mas-who or @edlerd for access.
   • With a local copy of this branch, build and run as described in the docs.
2. Perform the following QA steps:
   • Create an instance
   • Create a stateless snapshot and a stateful snapshot for the instance (migration.stateful must be true and the instance must be running)
   • Try duplicate both snapshots. Pay close attention to the stateful snapshot form validation.

[webteam-app]

Demo

Jenkins

demos.haus

[edlerd]

Oh nice, a new feature :)
Some suggestions on naming and copy. I think generally we should call it "Create instance from snapshot". And also update notifications to "Instance created" or "Instance creation failed". The context of coming from a snapshot is probably not important for the notifications.

[edlerd]

QA looks mostly good. I found one issue where the instance name is wrongly reported as the instance snapshot name. I think this comes from reading the values of the instance creation operation, that contains both the snapshot and the instance as a resource. See the attached screen for more details on this. This is also visible on the instance list, when the instance is being created. I think both paths (operation list and instance list) use the same function getInstanceName to get the instance name from the operation.

Code also mostly good, some small comments below.

[mas-who]

QA looks mostly good. I found one issue where the instance name is wrongly reported as the instance snapshot name. I think this comes from reading the values of the instance creation operation, that contains both the snapshot and the instance as a resource. See the attached screen for more details on this. This is also visible on the instance list, when the instance is being created. I think both paths (operation list and instance list) use the same function getInstanceName to get the instance name from the operation.

Code also mostly good, some small comments below.

Thanks for the hint here @edlerd , I made some adjustments to the getInstanceName function to handle the url encoded resource path returned by the backend. It will resolve the issue you observed above.

[edlerd]

QA and code LGTM, some nitpicks below. Maybe change the commit message also to say "Create instance from snapshot" the current "duplicate snapshot" is misleading.