Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: adjust generate certificate page layout #850

Merged
merged 1 commit into from
Aug 19, 2024

Conversation

mas-who
Copy link
Collaborator

@mas-who mas-who commented Aug 16, 2024

Done

  • Fixed styling for the generate certificate page

QA

  1. Run the LXD-UI:
  2. Perform the following QA steps:
    • N/A

Screenshots

Screenshot from 2024-08-16 15-46-45
Screenshot from 2024-08-16 15-47-00

@webteam-app
Copy link

Copy link
Collaborator

@edlerd edlerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the style fix, one more tiny observation on spacing below.

src/sass/_certificates.scss Outdated Show resolved Hide resolved
@mas-who mas-who force-pushed the fix-cert-page-layout branch from 5facd4d to 5e7f694 Compare August 16, 2024 15:34
Copy link
Collaborator

@edlerd edlerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perfect, thanks for the fixes.

@mas-who
Copy link
Collaborator Author

mas-who commented Aug 19, 2024

perfect, thanks for the fixes.

@edlerd Thanks for spotting the issue! :)

@mas-who mas-who merged commit 099e1eb into canonical:main Aug 19, 2024
12 checks passed
github-actions bot pushed a commit that referenced this pull request Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants