Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [WD-13704] Create image from backup file #848

Merged
merged 1 commit into from
Aug 22, 2024

Conversation

Kxiru
Copy link
Contributor

@Kxiru Kxiru commented Aug 15, 2024

Done

  • Added import tarball button as well as associated modal.
  • Minor scss changes
  • Additional API calls for importing the file and amending image properties.

QA

  1. Run the LXD-UI:
  2. Perform the following QA steps:
    • Upload a unified tarball image or a split tarball image to LXD-UI by selecting the "Import from Tarball" button on the Image list page.

Screenshots

image
image
image

@webteam-app
Copy link

Copy link
Collaborator

@mas-who mas-who left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still need to do QA and go through the notification copy. Left some code feedback so long :)

src/api/images.tsx Outdated Show resolved Hide resolved
src/api/images.tsx Outdated Show resolved Hide resolved
src/api/images.tsx Outdated Show resolved Hide resolved
@mas-who
Copy link
Collaborator

mas-who commented Aug 20, 2024

@Kxiru QA for the importing functionality looks good, I was able to:

  • import container and VM split tarballs
  • import container and VM unified tarballs

@Kxiru Kxiru force-pushed the create-image-from-backup-file branch from e66271e to e784e45 Compare August 21, 2024 15:02
@Kxiru Kxiru requested a review from mas-who August 21, 2024 15:06
src/pages/images/actions/ImportFromTarballBtn.tsx Outdated Show resolved Hide resolved
src/sass/_page_header.scss Show resolved Hide resolved
src/util/helpers.tsx Outdated Show resolved Hide resolved
src/util/helpers.tsx Outdated Show resolved Hide resolved
src/util/helpers.tsx Outdated Show resolved Hide resolved
src/api/images.tsx Outdated Show resolved Hide resolved
@Kxiru Kxiru force-pushed the create-image-from-backup-file branch from e784e45 to 5f8502d Compare August 21, 2024 17:04
@Kxiru Kxiru requested a review from edlerd August 21, 2024 17:04
@Kxiru Kxiru force-pushed the create-image-from-backup-file branch from 5f8502d to 065f450 Compare August 21, 2024 18:26
@Kxiru
Copy link
Contributor Author

Kxiru commented Aug 21, 2024

I believe this latest version is up to date, @edlerd , @mas-who . Please let me know your thoughts :)

Copy link
Collaborator

@edlerd edlerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the adjustments, this is now much more straight forward to read.

src/pages/images/actions/forms/UploadImageForm.tsx Outdated Show resolved Hide resolved
src/pages/images/actions/forms/UploadImageForm.tsx Outdated Show resolved Hide resolved
src/pages/images/actions/forms/UploadImageForm.tsx Outdated Show resolved Hide resolved
src/api/images.tsx Outdated Show resolved Hide resolved
src/pages/images/actions/forms/UploadImageForm.tsx Outdated Show resolved Hide resolved
src/pages/images/actions/forms/UploadImageForm.tsx Outdated Show resolved Hide resolved
src/api/images.tsx Outdated Show resolved Hide resolved
src/sass/_images.scss Outdated Show resolved Hide resolved
@Kxiru Kxiru force-pushed the create-image-from-backup-file branch from 065f450 to ce69b2f Compare August 22, 2024 11:19
@Kxiru Kxiru requested review from edlerd and mas-who August 22, 2024 11:19
edlerd
edlerd previously requested changes Aug 22, 2024
src/pages/images/actions/forms/UploadImageForm.tsx Outdated Show resolved Hide resolved
@Kxiru Kxiru force-pushed the create-image-from-backup-file branch from ce69b2f to 36ba854 Compare August 22, 2024 12:13
@Kxiru Kxiru requested a review from edlerd August 22, 2024 12:17
@mas-who

This comment was marked as resolved.

@Kxiru

This comment was marked as resolved.

@Kxiru Kxiru force-pushed the create-image-from-backup-file branch from 36ba854 to 07d334b Compare August 22, 2024 15:26
@Kxiru Kxiru requested a review from mas-who August 22, 2024 15:26
@Kxiru Kxiru force-pushed the create-image-from-backup-file branch from 07d334b to cea3345 Compare August 22, 2024 15:41
@Kxiru Kxiru requested a review from mas-who August 22, 2024 15:41
@mas-who
Copy link
Collaborator

mas-who commented Aug 22, 2024

LGTM, good work! Tested again and everything works well :)

Copy link
Collaborator

@edlerd edlerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for adding the upload.

@Kxiru Kxiru force-pushed the create-image-from-backup-file branch from cea3345 to d2236b7 Compare August 22, 2024 16:05
@Kxiru Kxiru merged commit fe13643 into canonical:main Aug 22, 2024
12 checks passed
github-actions bot pushed a commit that referenced this pull request Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants