Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add type checks in linting script [WD-13573] #827

Merged
merged 1 commit into from
Aug 2, 2024

Conversation

mas-who
Copy link
Collaborator

@mas-who mas-who commented Aug 2, 2024

Done

  • Added type checks to the lint-js script. This should pick up typescript errors that previously was missed during CI.
  • Fixed some Typescript errors that existed in the codebase

QA

  1. Run the LXD-UI:
  2. Perform the following QA steps:
    • N/A

@webteam-app
Copy link

Copy link
Contributor

@Kxiru Kxiru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing these changes!

@mas-who mas-who merged commit 506ca85 into canonical:main Aug 2, 2024
12 checks passed
github-actions bot pushed a commit that referenced this pull request Aug 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants