fix: publish image from snapshot created in a project that is not the default project

[mas-who]

Done

• Fixed the issue where publishing an image from a instance snapshot created in a non-default project fails

Fixes #824

QA

1. Run the LXD-UI:
   • On the demo server via the link posted by @webteam-app below. This is only available for PRs created by collaborators of the repo. Ask @mas-who or @edlerd for access.
   • With a local copy of this branch, build and run as described in the docs.
2. Perform the following QA steps:
   • Create a new project, use the "Customised" option
   • In the new project, create an instance and then a snapshot for that instance
   • publish an image for that snapshot should work as expected

[webteam-app]

Demo

Jenkins

demos.haus

[edlerd]

As this was a bug might be good to add a test case for this, wdyt?

[mas-who]

As this was a bug might be good to add a test case for this, wdyt?

Yes indeed, will add the test shortly.

[edlerd]

Thanks for adding the test! Some ideas to improve on the test code below.

[mas-who]

whilst trying to fix the failing CI test on firefox, I picked up an issue. The "select all" checkbox is shifted higher usual (see screenshot below)

This is caused by this style which I believe was a fix put in previously for safari. Removing it fixes the issue.

This is the cause for tests to fail on firefox, since we need to click the input element associated with the checkbox label span. With the span shifted higher, it overlays the input element which causes the click event to fail. To make the test pass, we can add the styling below:

.multiselect-checkbox input.p-checkbox__input {
  bottom: 0.5
}

This would shift the hidden input element up so that the label span no longer overlays the input. But I don't see this being a solution, @edlerd not sure if you have any ideas?

Edit: so adjusting the safari fix by negating the style on firefox works.

// fix for safari https://warthogs.atlassian.net/browse/WD-7486
.multiselect-checkbox span.p-checkbox__label {
  padding-left: 0;

  // applying the above style breaks the checkbox in firefox
  @-moz-document url-prefix() {
    padding-left: 2rem;
  }
}

[mas-who]

@edlerd ready for another pass thanks 🙂

[edlerd]

LGTM, thanks for the fix and adding a test for it.