fix(network) show physical managed network state #799
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Demo
Jenkins 
demos.haus 
edlerd
force-pushed
the
physical-network-state
branch
from
02a1fdf to
4ae85c2
Compare
mas-who
reviewed
Aug 27, 2024
mas-who
added
Review: QA +1
Review: Code +1
and removed
Review: QA needed
Review: Code needed
labels
|
QA and code LGTM, just one small nit comment, feel free to merge as is :) |
mas-who
approved these changes
Aug 27, 2024
…ble, show error message if it fails to load Signed-off-by: David Edler <[email protected]>
edlerd
force-pushed
the
physical-network-state
branch
from
4ae85c2 to
b6fd7be
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Done
QA
Note
This is pending canonical/lxd#13553 to improve the error message