Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(permissions) link identity groups count to edit panel #1033

Merged
merged 1 commit into from
Dec 16, 2024

Conversation

edlerd
Copy link
Collaborator

@edlerd edlerd commented Dec 16, 2024

Done

  • fix(permissions) link identity groups count to edit panel

QA

  1. Run the LXD-UI:
  2. Perform the following QA steps:
    • check permissions > identities list. The group count should be a shortcut to show and edit the linked groups for an identity.

@webteam-app
Copy link

@Kxiru
Copy link
Contributor

Kxiru commented Dec 16, 2024

Screenshots for visibility:
image
image

Copy link
Contributor

@Kxiru Kxiru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I understand the logic, but is it not redundant to have two buttons with the exact same functionlity, centimeters away from one another?

@edlerd
Copy link
Collaborator Author

edlerd commented Dec 16, 2024

I understand the logic, but is it not redundant to have two buttons with the exact same functionlity, centimeters away from one another?

Yes, but I think it serves a purpose, because as a user you might read the number and wonder immediately what are more details for it. Having a link available unblocks your thinking.

Also, this is to create parity with the behaviour in the group list.

Copy link
Contributor

@Kxiru Kxiru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair justification for the feature and code looks good to me! Thanks!

@edlerd edlerd merged commit 9665053 into canonical:main Dec 16, 2024
11 checks passed
@edlerd edlerd deleted the link-identities-group branch January 15, 2025 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants