Add lxd-stophook wrapper that redirects container stop callhooks to lxd-user #635
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This command is intended to replace the `lxd` command in the snap so that existing running containers that are stopping will call this script as part of their stop hooks. This will then "route" the command to the `lxd-user` command that will be statically compiled so that it can connect to the running LXD daemon via the unix socket to indicate the container is stopping, even after refreshing the LXD snap to a different core base snap. Signed-off-by: Thomas Parrott <[email protected]> (cherry picked from commit 4d10cbd)
The PATH inside the snap is configured to prefer /sbin over /bin so the lxd binary will still
be called by default.
The lxd-stophook-wrapper script which will be placed into `/bin/lxd`.
Because containers are configured to call `/snap/lxd/current/bin/lxd callhook` which in turn will be
routed to `/snap/lxd/current/bin/lxd-user` by the lxd-stophook-wrapper script, which will then connect
to LXD's unix socket to indicate to the server that the container is stopping.
Because lxd-user is compiled as a static binary this will work across snap core base changes.
Also update LXD_EXEC_PATH env var so that LXD will still directly execute itself when needed, rather
than going via the lxd-stophook wrapper script.
Signed-off-by: Thomas Parrott <[email protected]>
(cherry picked from commit 75de117)
tomponline
changed the title
|
Will follow up with a change to lxd itself that separately configures liblxc container's stop hook paths to use the lxd-stophook script in bin/lxd. |
simondeziel
approved these changes
Nov 25, 2024
tomponline
added a commit
to canonical/lxd
that referenced
this pull request
Nov 25, 2024
…of the snap instead of sbin (#14526) This is the historical path where the lxd binary used to be, but it was replaced with a small wrapper script which redirects the stop hook requests to lxd-user (which is statically compiled) so that stop hook notifications to LXD work when the snap base version is changed. Related to canonical/lxd-pkg-snap#635 Fixes #13331
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to canonical/lxd#14526
Related to canonical/lxd#13331