Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

snapcraft: use stable-6.0 branch of lxc part (5.21-edge) #524

Merged

Conversation

simondeziel
Copy link
Member

@simondeziel simondeziel commented Jul 17, 2024

I quickly glanced at the changes and LXC_DEVEL=0 caught my attention. There are quite a few commits from @mihalicyn we'd lose though, so maybe we should wait for 6.0.2?

@simondeziel simondeziel requested a review from mihalicyn July 17, 2024 19:24
@simondeziel simondeziel marked this pull request as ready for review July 17, 2024 19:24
@simondeziel simondeziel requested a review from tomponline as a code owner July 17, 2024 19:24
@simondeziel
Copy link
Member Author

Built fine:

Generated snap metadata                                                                                                                  
'--enable-manifest' is deprecated, and will be removed in core24.                                                                        
Version has been set to '0+git.db0a3cbf'                                                                                                 
Generated snap manifest                                                                                                                  
Lint warnings:                                                                                                                           
- library: libnvidia-container-go.so.1: unused library 'lib/libnvidia-container-go.so.1.14.6'. (https://snapcraft.io/docs/linters-library)                                                                                                                                         
- library: libatomic.so.1: unused library 'lib/x86_64-linux-gnu/libatomic.so.1.2.0'. (https://snapcraft.io/docs/linters-library)         
- library: libjson-glib-1.0.so.0: unused library 'lib/x86_64-linux-gnu/libjson-glib-1.0.so.0.600.6'. (https://snapcraft.io/docs/linters-library)                                                                                                                                   
- library: libusbredirhost.so.1: unused library 'lib/x86_64-linux-gnu/libusbredirhost.so.1.0.2'. (https://snapcraft.io/docs/linters-library)                                                                                                                                       
- library: libzpool.so.2: unused library 'zfs-0.8/lib/libzpool.so.2.0.0'. (https://snapcraft.io/docs/linters-library)                    
- library: libnvpair.so.3: unused library 'zfs-2.1/lib/libnvpair.so.3.0.0'. (https://snapcraft.io/docs/linters-library)                  
- library: libuutil.so.3: unused library 'zfs-2.1/lib/libuutil.so.3.0.0'. (https://snapcraft.io/docs/linters-library)                    
- library: libzfs.so.4: unused library 'zfs-2.1/lib/libzfs.so.4.1.0'. (https://snapcraft.io/docs/linters-library)                        
- library: libzfs_core.so.3: unused library 'zfs-2.1/lib/libzfs_core.so.3.0.0'. (https://snapcraft.io/docs/linters-library)              
- library: libzfsbootenv.so.1: unused library 'zfs-2.1/lib/libzfsbootenv.so.1.0.0'. (https://snapcraft.io/docs/linters-library)          
- library: libzpool.so.5: unused library 'zfs-2.1/lib/libzpool.so.5.0.0'. (https://snapcraft.io/docs/linters-library)                    
- library: libzfsbootenv.so.1: unused library 'zfs-2.2/lib/libzfsbootenv.so.1.0.0'. (https://snapcraft.io/docs/linters-library)          
- library: libzpool.so.5: unused library 'zfs-2.2/lib/libzpool.so.5.0.0'. (https://snapcraft.io/docs/linters-library)                    
Version has been set to '0+git.db0a3cbf'                                                                                                 
Created snap package lxd_0+git.db0a3cbf_amd64.snap

Copy link
Member

@tomponline tomponline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is the right think to do, the LTS point releases will use a specific tag any sha anyway.

@tomponline tomponline merged commit cc7edd5 into canonical:5.21-edge Jul 18, 2024
5 checks passed
@simondeziel simondeziel deleted the lxc-stable-branch-5.21-edge branch July 18, 2024 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants