Support for fully removing relations #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry for not noticing 6f48e5c before. Since the hook runs every time, it writes the conf file every time and then restarts the service. |
lazypower
suggested changes
Oct 1, 2017
|
Sorry @chuckbutler I was super busy recently. I will have a look at this. Will get back to you soon. About maintaining. Better not, I don't know much at all about Elastic. I just added the features I needed. But I'm glad to help with anything. I don't mind at all to play around with charms if I have the time. :) |
…o issue/16 Solved Conflicts: reactive/filebeat.py
|
Done. Was basically a whitespace fix. |
|
Ack. This should solve #25 |
lazypower
approved these changes
Oct 8, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes canonical/layer-beats-base#16