-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/app #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test is failing due to: canonical/pylxd#580 should be fixed when it lands on pypi. |
yanksyoon
commented
May 31, 2024
yanksyoon
commented
May 31, 2024
pyproject.toml
Outdated
|
||
[project] | ||
name = "github-runner-image-builder" | ||
version = "0.0.1" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
0.1 -> 1.0.0 after stable
yanksyoon
commented
May 31, 2024
yanksyoon
commented
May 31, 2024
yanksyoon
commented
May 31, 2024
yanksyoon
commented
May 31, 2024
yanksyoon
commented
May 31, 2024
yanksyoon
commented
May 31, 2024
yanksyoon
commented
May 31, 2024
yanksyoon
commented
May 31, 2024
yanksyoon
commented
May 31, 2024
yanksyoon
commented
May 31, 2024
yanksyoon
commented
May 31, 2024
yanksyoon
commented
May 31, 2024
yanksyoon
commented
May 31, 2024
yanksyoon
commented
May 31, 2024
yanksyoon
commented
May 31, 2024
yanksyoon
commented
May 31, 2024
yanksyoon
commented
May 31, 2024
yanksyoon
commented
May 31, 2024
yanksyoon
commented
May 31, 2024
yanksyoon
commented
May 31, 2024
jdkandersson
previously approved these changes
Jun 13, 2024
arturo-seijas
previously approved these changes
Jun 13, 2024
yanksyoon
dismissed stale reviews from arturo-seijas and jdkandersson
via
June 14, 2024 02:52
827471d
arturo-seijas
previously approved these changes
Jun 14, 2024
jdkandersson
approved these changes
Jun 18, 2024
javierdelapuente
approved these changes
Jun 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Force pushing due to unsigned commits closed #2 and github currently cannot reopen closed PRs due to foce push, hence a new PR.
Applicable spec: N/A
Overview
Creates an installable python application that will be used by github-runner-image-builder-operator charm to manage building of images.
The application creates a chroot environment from Ubuntu cloud-images and pre-installs and pre-configures executables.
The uploading of images have been omitted deliberately due to the testing overhead that arises from including Openstack.
Rationale
To provide a workload for github-runner-image-builder-operator charm.
Module Changes
The modules are as follows:
cli
- provides entrypoint and parsing argsbulider
- handles the building of image within the chroot envchroot
- provides a context-managed chroot environmentconfig
- configuration data typesutils
- utility functions, e.g. retryTODO (in a follow up PR):
Checklist
src-docs
urgent
,trivial
,complex
)The following is the result of running the test on the ARM64 AWS instance. The error is due to unavailability of private-endpoint-arm runners and hence the failure to cleanup Openstack image resources.
The following is the result of testing on PS6 ARM64 runner instances.