Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/app #4

Merged
merged 64 commits into from
Jun 19, 2024
Merged

Feat/app #4

merged 64 commits into from
Jun 19, 2024

Conversation

yanksyoon
Copy link
Collaborator

@yanksyoon yanksyoon commented May 29, 2024

Force pushing due to unsigned commits closed #2 and github currently cannot reopen closed PRs due to foce push, hence a new PR.

Applicable spec: N/A

Overview

Creates an installable python application that will be used by github-runner-image-builder-operator charm to manage building of images.
The application creates a chroot environment from Ubuntu cloud-images and pre-installs and pre-configures executables.
The uploading of images have been omitted deliberately due to the testing overhead that arises from including Openstack.

Rationale

To provide a workload for github-runner-image-builder-operator charm.

Module Changes

The modules are as follows:

  • cli - provides entrypoint and parsing args
  • bulider - handles the building of image within the chroot env
  • chroot - provides a context-managed chroot environment
  • config - configuration data types
  • utils - utility functions, e.g. retry

TODO (in a follow up PR):

  • reorder the functions to be in step down order to cater for recent changes in contributing guide.
  • Missing repository configurations.

Checklist

The following is the result of running the test on the ARM64 AWS instance. The error is due to unavailability of private-endpoint-arm runners and hence the failure to cleanup Openstack image resources.
image

The following is the result of testing on PS6 ARM64 runner instances.
image
image
image
image
image
image

@cbartz cbartz added the complex label May 29, 2024
@yanksyoon
Copy link
Collaborator Author

The test is failing due to: canonical/pylxd#580 should be fixed when it lands on pypi.

pyproject.toml Outdated

[project]
name = "github-runner-image-builder"
version = "0.0.1"
Copy link
Collaborator Author

@yanksyoon yanksyoon May 31, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0.1 -> 1.0.0 after stable

pyproject.toml Outdated Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
requirements.txt Outdated Show resolved Hide resolved
jdkandersson
jdkandersson previously approved these changes Jun 13, 2024
arturo-seijas
arturo-seijas previously approved these changes Jun 13, 2024
@yanksyoon yanksyoon dismissed stale reviews from arturo-seijas and jdkandersson via 827471d June 14, 2024 02:52
arturo-seijas
arturo-seijas previously approved these changes Jun 14, 2024
@yanksyoon yanksyoon merged commit f9f1c74 into main Jun 19, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants