breaking: Use charmcraftcache for builds instead of GitHub Actions cache
#115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cache Breaking changes for charms with "pack-wrapper" environment in tox.ini: - tox environment "pack-wrapper" renamed to "build-wrapper" - tox environment "build" renamed to "build-production" - new tox environment "build-dev" for cached builds
carlcsaposs-canonical
requested review from
paulomach,
taurus-forever and
dragomirp
|
Tested on canonical/mysql-router-k8s-operator#180 |
|
Synchronize merge with canonical/charmcraftcache-hub#29 |
taurus-forever
approved these changes
Jan 8, 2024
The tox config for that is more complicated (if it's even possible)—unless the non-production build environment name does not contain Also I don't think it will help with backwards compatibility—I only think it will make things fail silently |
carlcsaposs-canonical
added a commit
that referenced
this pull request
Jan 8, 2024
carlcsaposs-canonical
added a commit
that referenced
this pull request
Jan 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking changes for charms with "pack-wrapper" environment in tox.ini:
Example migration for breaking changes: canonical/mysql-router-k8s-operator@8f30968