linters: set disallow_untyped_defs in mypy #350

tigarmo · 2023-01-16T20:28:05Z

This forces type annotations for functions in craft_parts/.

This forces type annotations for functions in craft_parts/.

SourceHandler._run() takes a List[str], so it's incorrect to pass a Path.

tigarmo · 2023-01-17T13:48:02Z

@cmatsuoka the second commit has test code that I had to update on account of typing fixes

craft_parts/executor/executor.py

craft_parts/executor/step_handler.py

craft_parts/overlays/overlay_manager.py

craft_parts/packages/snaps.py

craft_parts/sources/base.py

craft_parts/sources/git_source.py

lengau

Everything I've commented has been the rambling thoughts of someone new to the codebase, so take them for what they're worth there

tigarmo · 2023-01-18T13:29:48Z

@lengau the comments are much appreciated, thanks. Updated the PR based on your suggestions

tigarmo force-pushed the stricter-mypy branch 2 times, most recently from 45ff414 to 5c08212 Compare January 17, 2023 12:12

tigarmo added 2 commits January 17, 2023 09:36

linters: set disallow_untyped_defs in mypy

661c8fd

This forces type annotations for functions in craft_parts/.

fix tests that expected a Path instead of a str

0406a70

SourceHandler._run() takes a List[str], so it's incorrect to pass a Path.

tigarmo force-pushed the stricter-mypy branch from 5c08212 to 0406a70 Compare January 17, 2023 12:37

tigarmo marked this pull request as ready for review January 17, 2023 13:47

tigarmo requested a review from cmatsuoka January 17, 2023 13:48