Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't require a specific python interpreter for uv #1003

Merged
merged 8 commits into from
Feb 5, 2025

Conversation

bepri
Copy link
Contributor

@bepri bepri commented Feb 3, 2025

  • Have you signed the CLA?
  • Have you added an entry to the changelog (docs/reference/changelog.rst)?

Closes #991.
CRAFT-4010

@bepri bepri self-assigned this Feb 3, 2025
@bepri bepri requested review from tigarmo and lengau February 3, 2025 19:16
@bepri bepri marked this pull request as ready for review February 3, 2025 19:17
@bepri bepri requested a review from tigarmo February 4, 2025 15:30
@bepri
Copy link
Contributor Author

bepri commented Feb 4, 2025

Rockcraft PR using this fix and removing its own fix for the problem: canonical/rockcraft#803

Copy link
Contributor

@lengau lengau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fix!

Copy link
Contributor

@tigarmo tigarmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Please wait for the rockcraft PR to pass before merging this

@tigarmo
Copy link
Contributor

tigarmo commented Feb 5, 2025

@bepri :shipit: !

@bepri bepri merged commit 3fb0f27 into main Feb 5, 2025
13 checks passed
@bepri bepri deleted the work/uv-plugin-system-interpreter/CRAFT-4010 branch February 5, 2025 18:52
@mr-cal mr-cal mentioned this pull request Feb 7, 2025
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

uv plugin fails if _get_system_python_interpreter returns None
3 participants