Starbase migration #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on-test # Conflicts: # tox.ini
Most static checks don't need the code to be installed at all, but type checking can require the code and its dependencies.
tools: Make typing use an editable install
tests: Ensure coverage gets per-environment filenames
Done the same way as in rockcraft Co-authored-by: Tiago Nobrega <[email protected]>
docs: Basic sphinx docs
Rather than statically declaring the project to be "starcraft" all over the place, prefer excluding directories.
chore(tools): Make pyproject.toml exclude rather than statically include
chore(deps): update dependency tox to v4.4.2
chore(deps): update release-drafter/release-drafter action to v5.22.0
chore(deps): update dependency tox-ignore-env-name-mismatch to v0.2.0.post2
chore(deps): update dependency pytest to v7.2.1
Ensure that ruff only gets updated by renovate or explicitly in PRs. This will prevent random CI breakages until ruff is stable.
New ignore: Too many arguments on test functions * chore(lint): Ruff autofixes for new pylint
This move the configuration from setup.cfg to pyproject.toml.
No manual changes; only automated ones.
We can revert this later but for the Starbase integration this fails on a huge number of commits coming from starbase.
This fixes a circular import between the statement types and the processor.
We don't have structured docs in craft-grammar yet.
lengau
reviewed
Apr 23, 2024
lengau
reviewed
Apr 23, 2024
lengau
reviewed
Apr 23, 2024
lengau
reviewed
Apr 23, 2024
lengau
reviewed
Apr 23, 2024
lengau
approved these changes
Apr 23, 2024
``test_create_model.py`` tests old-style typing annotations on purpose, to check the behavior of e.g. both "X | None" and "Optional[X]".
All tasks are done via `tox` instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The commits after the
chore: merge 'starbase/main'one are the ones to review: I tried to commit as I advanced a step, signaling whether the changes were automated or not.