net/sysconfig: do not remove all existing settings of /etc/sysconfig/network #5991
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…network In some distros, /etc/sysconfig/network may have important cconfigurations that are necessary for the instance to come up. For example, centos based distros write NOZEROCONF=yes in /etc/sysconfig/network for some instances that require zeroconf to be disabled. Removing these customizations would prevent the instance to come up. So leave the customizations in /etc/sysconfig/network intact except those that we are interested in. Fixes canonicalGH-5990 Signed-off-by: Ani Sinha <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Commit Message
In some distros, /etc/sysconfig/network may have important cconfigurations that are necessary for the instance to come up. For example, centos based distros write NOZEROCONF=yes in /etc/sysconfig/network for some instances that require zeroconf to be disabled. Removing these customizations would prevent the instance to come up. So leave the customizations in /etc/sysconfig/network intact except those that we are interested in.
Fixes GH-5990
Signed-off-by: Ani Sinha [email protected]
Merge type