Clarify subiquity docs #5957
Clarify subiquity docs #5957
Conversation
Cloud-init ignores this key and its contents. Dispell confusion with clearer messaging and more user-friendly language.
Schema validation is automatically checked and reported through cloud-init status. Eliminate unnecessary manual verification as well as the autoinstall key check which is unnecessary due to activation_key.
github-actions
bot
added
the
documentation
| @@ -73,14 +46,6 @@ class TestHandleAutoinstall: | |||
| @pytest.mark.parametrize( | |||
| "cfg,snap_list,subp_calls,logs,snap_wait_called", | |||
| [ | |||
| pytest.param( | |||
There was a problem hiding this comment.
This never happens in the codebase due to activate_by_schema_keys: autoinstall.
holmanb
force-pushed
the
holmanb/subiquity-docs
branch
from
0f463e9 to
578b76b
Compare
| @@ -38,33 +38,6 @@ | |||
| ) | |||
|
|
|||
|
|
|||
| class TestvalidateConfigSchema: | |||
There was a problem hiding this comment.
Coverage on this module remains at 100% after removing these tests.
| cloud-init on the target system. See | ||
| `the Ubuntu installer documentation <https://canonical-subiquity.readthedocs-hosted.com/en/latest/reference/autoinstall-reference.html#user-data>`_ | ||
| for more information. | ||
| The autoinstaller might pass part of this configuration to cloud-init |
There was a problem hiding this comment.
We're using "Ubuntu installer" and "autoinstaller" interchangeably here - could we standardise on one for consistency?
|
Hello! Thank you for this proposed change to cloud-init. This pull request is now marked as stale as it has not seen any activity in 14 days. If no activity occurs within the next 7 days, this pull request will automatically close. If you are waiting for code review and you are seeing this message, apologies! Please reply, tagging TheRealFalcon, and he will ensure that someone takes a look soon. (If the pull request is closed and you would like to continue working on it, please do tag TheRealFalcon to reopen it.) |
github-actions
bot
added
the
stale-pr
Merge type