Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: enable ignoring of fileglobs #2051

Merged
merged 3 commits into from
Dec 18, 2024
Merged

test: enable ignoring of fileglobs #2051

merged 3 commits into from
Dec 18, 2024

Conversation

bepri
Copy link
Contributor

@bepri bepri commented Dec 17, 2024

The copyright header test would scan any .py source file, but sometimes files do not need a Canonical copyright header.

As an example, in #2050, a spread test was added that contained a directory generated by uv init. This command makes a pretty minimal Python hello world, and the copyright header test was failing it.

The copyright header test would scan any .py source file, but sometimes files do not need a Canonical copyright header.
@bepri bepri self-assigned this Dec 17, 2024
@bepri bepri requested a review from lengau as a code owner December 17, 2024 21:58
@bepri bepri requested a review from a team December 17, 2024 22:03
@bepri bepri force-pushed the work/copyright-file-globs branch from 52f43fb to e6c2d5e Compare December 17, 2024 23:03
@bepri
Copy link
Contributor Author

bepri commented Dec 17, 2024

Force push was to correct some commits that mistakenly broke conventional commits

@bepri bepri requested review from lengau and a team December 18, 2024 13:32
@lengau lengau added this pull request to the merge queue Dec 18, 2024
Merged via the queue into main with commit c952210 Dec 18, 2024
28 checks passed
@lengau lengau deleted the work/copyright-file-globs branch December 18, 2024 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants