Check missing links for engage pages

[carkod]

Done

• Check missing links for engage pages

QA

Use this PR

Issue

Fixes #75

[nottrobin]

As you suggested face-to-face, let's make use of flask.current_app.extensions["sentry"] to notify Sentry of these problems - probably you want captureMessage.

As I mentioned you should be able to locally test sending sentry messages by setting the SENTRY_DSN env var in .env.local. I think.

[carkod]

As you suggested face-to-face, let's make use of flask.current_app.extensions["sentry"] to notify Sentry of these problems - probably you want captureMessage.

As I mentioned you should be able to locally test sending sentry messages by setting the SENTRY_DSN env var in .env.local. I think.

You also suggested to directly put the error messages on /engage, and I thought that was a better solution, that will allow not only developers but the marketing team to be able to spot these issues, as they will not likely check Sentry. Do I still need to add it to Sentry? The error messages will be the same.

[nottrobin]

@carkod I thought we agreed on doing both.

Do errors on the engage page even catch every problem? Aren't there going to be 500 pages if you try to visit the engage pages in question? Or does something else happen?

Anyway, we should do both.

[carkod]

@carkod I thought we agreed on doing both.

Do errors on the engage page even catch every problem? Aren't there going to be 500 pages if you try to visit the engage pages in question? Or does something else happen?

Anyway, we should do both.

So Sentry has to be attached to a service, so it doesn't work on the module, I have done it on ubuntu.com PR you should see a message like this once you add the DSN of that sentry project to your env.local

[SirSamTumless]

What's happening with this @carkod ?

[nottrobin]

@carkod presumably you could simply pass through the SENTRY_DSN to this module (make it optional) and then this module could do the reporting? 'cos everywhere would benefit from this functionality.

[nottrobin]

@carkod really? that doesn't work? What happened when you tried?

[SirSamTumless]

@carkod What's happening with this - will you tackle it this week?

[nottrobin]

Tried switching to 18033 as you suggested and going to /engage - got:

[nottrobin]

Once the two comments are addressed (and you make the linter happy), I'm happy with this. So once it's unblocked by canonical/ubuntu.com#9601, we can do a final test and merge it.