Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle images in links #179

Merged
merged 3 commits into from
Nov 21, 2023
Merged

Handle images in links #179

merged 3 commits into from
Nov 21, 2023

Conversation

Lukewh
Copy link
Contributor

@Lukewh Lukewh commented Nov 21, 2023 •
edited
Loading

Handle images within a discourse topic - https://discourse.charmhub.io/t/observe-your-charm-with-cos-lite/7814 for example.

QA:

@anthonydillon anthonydillon self-assigned this Nov 21, 2023
anthonydillon
anthonydillon approved these changes Nov 21, 2023
View reviewed changes
Copy link
Contributor

@anthonydillon anthonydillon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code and QA 👍 nice one for adding the test 🚀

@Lukewh Lukewh merged commit 96c8c01 into main Nov 21, 2023
4 checks passed
@Lukewh Lukewh deleted the handle-images branch November 21, 2023 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anthonydillon anthonydillon anthonydillon approved these changes

Assignees

@anthonydillon anthonydillon

Labels
Review: Code +1 Review: QA +1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Lukewh @anthonydillon