Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace emdash with -- in topic paths to be url compatible #145 #146

Merged
merged 1 commit into from
Oct 4, 2022

Conversation

edlerd
Copy link
Contributor

@edlerd edlerd commented Sep 30, 2022

Signed-off-by: David Edler [email protected]

Fixes #145

@petesfrench
Copy link
Contributor

@jkfran Do you know how I can QA this?

@jkfran
Copy link
Contributor

jkfran commented Oct 3, 2022

Thank you for this contribution, @edlerd. Could you also increase the version in the setup.py to release a new version?

@jkfran Do you know how I can QA this?

Hey @petesfrench, you need:

  • Run a project with Discourse, like ubuntu.com docs
  • Use this version of the module with these changes. To do it, update the requirements.txt file in the project and replace canonicalwebteam.discourse with git+git://github.com/edlerd/canonicalwebteam.discourse@fix-emdash#egg=canonicalwebteam.discourse
  • Update the index topic on Discourse to have URLs with -- to see what happens. You might need to give this a read https://discourse.canonical.com/t/creating-discourse-based-documentation-pages/159 to understand how the URL mapping works.

@edlerd
Copy link
Contributor Author

edlerd commented Oct 4, 2022

Added the version bump in setup.py to my commit.

Copy link
Contributor

@carkod carkod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@carkod carkod mentioned this pull request Oct 4, 2022
@jkfran jkfran merged commit 15f00f8 into canonical:main Oct 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for emdash (—) in URLs
4 participants