builtIn types should not warn about safe string #666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phillipskevin
previously requested changes
Jan 18, 2019
test/stache-test.js
Outdated
| @@ -6373,10 +6373,10 @@ function makeTest(name, doc, mutation) { | |||
|
|
|||
| }); | |||
|
|
|||
| testHelpers.dev.devOnlyTest("Arrays warn about escaping (#600)", 3, function () { | |||
| testHelpers.dev.devOnlyTest(" (#600)", 3, function () { | |||
There was a problem hiding this comment.
why did this testname change?
src/mustache_core.js
Outdated
| @@ -381,7 +381,7 @@ var core = { | |||
| else if(state.text && !valueShouldBeInsertedAsHTML(value)) { | |||
| //!steal-remove-start | |||
| if (process.env.NODE_ENV !== 'production') { | |||
| if(value !== null && typeof value === "object") { | |||
| if(value !== null && typeof value === "object" && canReflect.isBuiltIn(value) === false) { | |||
There was a problem hiding this comment.
Can you just use !canReflect.isBuiltIn(value)?
| @@ -6376,7 +6376,7 @@ function makeTest(name, doc, mutation) { | |||
| testHelpers.dev.devOnlyTest("Arrays warn about escaping (#600)", 3, function () { | |||
|
|
|||
| var map = new SimpleMap({ | |||
| foo: ["<p></p>"] | |||
| foo: new DefineList(["<p></p>"]) | |||
There was a problem hiding this comment.
It seems like #600 was specifically about Arrays, although I can't tell for sure, so I am not sure what is right here. I'm going to dismiss my review, but I think you should wait for @justinbmeyer to weigh in before merging.
There was a problem hiding this comment.
Yeah, I suppose Array and Objects are built-ins. Maybe the solution here is to do nothing until a Major release and then remove this warning. Or we should tell people to call obj.toString() in the warning.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #613
The expected behavior
When rendering a built in type (e.g: Date), stache shouldn't warn about using
stache.safeString.The changes:
With the use of
canReflect.builtInI Check if the rendered object is built in one.