Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: perform autoreg waiting when performing standard autoreg #3461

Merged
merged 2 commits into from
Oct 1, 2024

Conversation

ptoscano
Copy link
Contributor

@ptoscano ptoscano commented Oct 1, 2024

The initial delay when performing the standard autoregistration used to
be done directly in rhsmcertd (the C daemon). When the anonymous
autoregistration was implemented, since it has to start immediately,
that delay in rhsmcertd was dropped in favour of doing it "inline"
during the autoregistration. The waiting was added only during the
anonymous autoregistration flow and not during the standard
autoregistration.

Hence, add the autoregistration wait/delay before performing the
standard autoregistration, restoring the previous behaviour.

There is a small commit factorizing the code to an helper function.

Move the code that performs the waiting/delay during automatic
registration in its own function; this way it can be reused also in
other places.

This is only a code recfatoring, there is no behaviour changes.
The initial delay when performing the standard autoregistration used to
be done directly in rhsmcertd (the C daemon). When the anonymous
autoregistration was implemented, since it has to start immediately,
that delay in rhsmcertd was dropped in favour of doing it "inline"
during the autoregistration. The waiting was added only during the
anonymous autoregistration flow and not during the standard
autoregistration.

Hence, add the autoregistration wait/delay before performing the
standard autoregistration, restoring the previous behaviour.
@cnsnyder cnsnyder requested review from a team and m-horky and removed request for a team October 1, 2024 13:14
Copy link

github-actions bot commented Oct 1, 2024

Coverage

Coverage (computed on Fedora latest) •
FileStmtsMissCoverMissing
subscription_manager/scripts
   rhsmcertd_worker.py19212236%42–45, 87, 92–95, 100–101, 106–109, 149, 169–171, 173–175, 179, 188, 190, 194–196, 200, 203–206, 209, 212–213, 219–221, 223–227, 229–230, 240, 242, 244–245, 262, 265–266, 269, 272, 274–275, 278–280, 283, 287–294, 298–300, 303, 307–309, 311, 317, 319, 321–324, 326–328, 330–331, 335, 337, 339, 341, 343–345, 347, 349–350, 352–356, 362–363, 367, 369, 373, 375–377, 387–390, 395–400, 404
TOTAL17819451274% 

Tests Skipped Failures Errors Time
2489 14 💤 0 ❌ 0 🔥 35.003s ⏱️

Copy link
Contributor

@m-horky m-horky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@m-horky m-horky merged commit 0d27a59 into main Oct 1, 2024
17 checks passed
@m-horky m-horky deleted the ptoscano/autoregv1-wait branch October 1, 2024 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants