Cockpit: Implement modal dialog #1716
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kahowell
force-pushed
the
khowell/cockpit_modal
branch
from
0bbd079
to
f6f8779
Compare
kahowell
force-pushed
the
khowell/cockpit_modal
branch
from
f6f8779
to
1f50ba6
Compare
kahowell
force-pushed
the
khowell/cockpit_modal
branch
from
1f50ba6
to
000612b
Compare
Merged
kahowell
force-pushed
the
feature/cockpit
branch
from
45126b4
to
dda9833
Compare
Implementation is from https://github.com/cockpit-project/cockpit/blob/c04c148225c59d2f053300d80b6b4731e421b8e6/pkg/lib/cockpit-components-dialog.jsx . It's been cleaned up a bit in order to satisfy switching to React from react-lite, as well as to clean up a few warnings. See the diff of src/cockpit-components-dialog.jsx to the link above for changes. I also made a few changes in order to get the registration flow to work and general improvements: - fixed the registration method in subscriptions-client.js - removed the ensure registered requirement from the products service - removed tracebacks from error messages emitted by the D-Bus services - added the extract-text-webpack-plugin to webpack to produce subscriptions.css
kahowell
force-pushed
the
khowell/cockpit_modal
branch
from
000612b
to
a695c30
Compare
|
Changes to cockpit-components-dialog.jsx: https://gist.github.com/kahowell/3471d83d173f30e24067bf953616edb5 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation is from https://github.com/cockpit-project/cockpit/blob/c04c148225c59d2f053300d80b6b4731e421b8e6/pkg/lib/cockpit-components-dialog.jsx .
It's been cleaned up a bit in order to satisfy switching to React from
react-lite, as well as to clean up a few warnings. See the diff of
src/cockpit-components-dialog.jsx to the link above for changes.
I also made a few changes in order to get the registration flow to work
and general improvements: