Wasm imports #433
Merged
Wasm imports #433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fawadasaurus
approved these changes
Sep 7, 2023
|
Converted to draft while I work on some components that leverage this feature to make sure it satisfies requirements. |
BREAKING CHANGE: Box<StdError...> may need to be converted into anyhow::Error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the ability for wasm components to import components directly vs. forcing components to be provided via the required/provides relationship.
Also in this PR:
[op_name]_rawactually raw. They now only take and return a single stream of packets. The old implementation had excess generated code in it which cause the interface to be weird and not-at-all raw.[op_name]always "not raw" - as in they will ignore the global raw setting. This is in preparation for the removal of the raw settings.