Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: still return a result for protein/cdna with no mane data found #507

Merged
merged 2 commits into from
Sep 6, 2023

Conversation

korikuzma
Copy link
Member

@korikuzma korikuzma commented Sep 1, 2023

close #505

Create temp enum, this will be fixed in cool-seq-tool + fix move sorting for preferred translation result

@korikuzma korikuzma added bug Something isn't working priority:high High priority labels Sep 1, 2023
@korikuzma korikuzma self-assigned this Sep 1, 2023
- Also creates an enum for vrs sequence location accession status. This
  will be replaced by TranscriptPriority enum in cool-seq-tool once it
is updated
@korikuzma korikuzma linked an issue Sep 4, 2023 that may be closed by this pull request
@korikuzma korikuzma marked this pull request as draft September 5, 2023 12:28
@korikuzma korikuzma removed the request for review from jsstevenson September 5, 2023 12:28
@korikuzma
Copy link
Member Author

Converting to draft because we have a similar issue to #502 when running this branch
Screenshot 2023-09-05 at 8 26 34 AM

@korikuzma korikuzma merged commit 460a631 into refactor Sep 6, 2023
@korikuzma korikuzma deleted the issue-505 branch September 6, 2023 15:24
korikuzma added a commit that referenced this pull request Sep 7, 2023
* Originally done in #507
* Creates an enum for vrs sequence location accession status
* Fix getting priority translation result in `_get_priority_translation_result` when there are multiple translation results for a given ac status
korikuzma added a commit that referenced this pull request Sep 22, 2023
…507)

- Creates an enum for vrs sequence location accession status
- Fix getting priority translation result in `_get_priority_translation_result` when there are multiple translation results for a given ac status
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working priority:high High priority
Projects
None yet
Development

Successfully merging this pull request may close these issues.

refactor branch: if no mane data is found, still return a result
2 participants