Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add vrs-python's translator to method #252

Closed
korikuzma opened this issue Mar 7, 2022 · 4 comments · Fixed by #288 or #292
Closed

Add vrs-python's translator to method #252

korikuzma opened this issue Mar 7, 2022 · 4 comments · Fixed by #288 or #292
Assignees
@korikuzma

Comments

@korikuzma
Copy link
Member

This was going to be done in #246 but due to this issue, we're going to hold off until I have more time to look into fixing this.
@korikuzma korikuzma self-assigned this Mar 7, 2022
@korikuzma korikuzma mentioned this issue Mar 7, 2022
Closed
@korikuzma korikuzma mentioned this issue May 9, 2022
Merged
@korikuzma
Copy link
Member Author

This is needed for Vrs-Python's cloud based notebooks as seen here

@korikuzma korikuzma mentioned this issue May 21, 2022
Merged
@korikuzma korikuzma linked a pull request May 21, 2022 that will close this issue
feat: add endpoint for vrs-python's translate_to method #288
Merged
@github-actions
Copy link

Closed by #288.

@korikuzma
Copy link
Member Author

Re-opening to switch from Request to pydantic.BaseModel to be passed

@korikuzma korikuzma reopened this May 24, 2022
@korikuzma korikuzma mentioned this issue May 24, 2022
Merged
@korikuzma korikuzma linked a pull request May 24, 2022 that will close this issue
fix: use pydantic.BaseModel for translate_to so fastapi ui can be used #292
Merged
@github-actions
Copy link

Closed by #292.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@korikuzma korikuzma

Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@korikuzma