Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sample meta validate input: leading or tailing spaces in file paths are kept in output, error should be raised or remove spaces #20

Closed
byb121 opened this issue May 15, 2017 · 2 comments
Assignees
Labels

Comments

@byb121
Copy link
Contributor

byb121 commented May 15, 2017

Sample meta validate input:
Code is removing leading and tailing spaces when validating file paths, but kept them in the output. Downstream process of the output should be aware of this.

@byb121 byb121 added the bug label May 15, 2017
@keiranmraine
Copy link
Contributor

@byb121 , can you provide an example causing this to occur. Unless the file path has been quoted I would expect the shell to remove additional whitespace.

@byb121 byb121 self-assigned this Jul 19, 2017
@byb121
Copy link
Contributor Author

byb121 commented Jul 19, 2017

The code takes whatever in the input file and dump them into the output, then adds more columns. When calling shell commands, the code removes leading/tailing whitespaces. So validation won't raise an error, but the output will have those whitespaces kept.

I use python code to take the file paths from the output and subprocess to call shell commands, and it does not tolerate tailing spaces. I think subprocess unfortunately does quote commands.

I'll fix it next week.

@byb121 byb121 changed the title Sample meta validate input: leading or trailing spaces in file paths are kept in output, error should be raised or remove spaces Sample meta validate input: leading or tailing spaces in file paths are kept in output, error should be raised or remove spaces Jul 19, 2017
@byb121 byb121 mentioned this issue Jul 19, 2017
@keiranmraine keiranmraine mentioned this issue Feb 14, 2018
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants