Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Proposal] remove most rxjs-related code from the SegmentBuffers and transport code #916

Closed
wants to merge 7 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/core/api/option_utils.ts
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ import { IRepresentationFilter } from "../../manifest";
import {
CustomManifestLoader,
CustomSegmentLoader,
ILoadedManifest,
ILoadedManifestFormat,
ITransportOptions as IParsedTransportOptions,
} from "../../transports";
import arrayIncludes from "../../utils/array_includes";
Expand Down Expand Up @@ -84,7 +84,7 @@ export interface ITransportOptions {
*/
checkMediaSegmentIntegrity? : boolean;
/** Manifest object that will be used initially. */
initialManifest? : ILoadedManifest;
initialManifest? : ILoadedManifestFormat;
/** Custom implementation for performing Manifest requests. */
manifestLoader? : CustomManifestLoader;
/** Possible custom URL pointing to a shorter form of the Manifest. */
Expand Down Expand Up @@ -272,7 +272,7 @@ interface IParsedLoadVideoOptionsBase {
url : string | undefined;
transport : string;
autoPlay : boolean;
initialManifest : ILoadedManifest | undefined;
initialManifest : ILoadedManifestFormat | undefined;
keySystems : IKeySystemOption[];
lowLatencyMode : boolean;
minimumManifestUpdateInterval : number;
Expand Down
2 changes: 1 addition & 1 deletion src/core/api/public_api.ts
Original file line number Diff line number Diff line change
Expand Up @@ -773,7 +773,7 @@ class Player extends EventEmitter<IPublicAPIEvent> {
maxRetryOffline: offlineRetry });

/** Interface used to download segments. */
const segmentFetcherCreator = new SegmentFetcherCreator<any>(
const segmentFetcherCreator = new SegmentFetcherCreator(
transportPipelines,
{ lowLatencyMode,
maxRetryOffline: offlineRetry,
Expand Down
50 changes: 0 additions & 50 deletions src/core/fetchers/manifest/get_manifest_backoff_options.ts

This file was deleted.

Loading