-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: add test for getMediaKeySystemAccess(); #1603
base: fix/comprehensive-cached-check
Are you sure you want to change the base?
test: add test for getMediaKeySystemAccess(); #1603
Conversation
81a1745
to
4c6ab36
Compare
I think tests for The idea of
So we decided some years ago to have test relying on the module's (in this case the Moreover just to clarify here, I've nothing against unit tests at lower levels, and I think that it's a net good thing to add some, most of all for testing that some code does what we think it does in some edge cases. |
e5b2cde
to
87df748
Compare
4c6ab36
to
0c4e7be
Compare
}), | ||
}), | ||
getConfiguration: () => { | ||
return baseEmeConfiguration; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
getConfiguration
e.g. distinctiveIdentifier
is returned as optional
, something that it cannot be:
All values in the configuration may be used in any combination. Members of type MediaKeysRequirement reflect whether the capability is required for any combination. They will not have the value "optional".
Anyway we don't care for this test and this is a nitpick
add unit test for
getMediaKeySystemAccess()