[Proposal] Add to config most compat switches #1514
+164
−33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peaBerberian
added
the
proposal
peaBerberian
force-pushed
the
misc/config-compat
branch
2 times, most recently
from
2f2b47c to
3393b46
Compare
peaBerberian
force-pushed
the
misc/re-export-config
branch
from
86fc351 to
34323ec
Compare
peaBerberian
force-pushed
the
misc/config-compat
branch
2 times, most recently
from
11b90ef to
e353d59
Compare
peaBerberian
force-pushed
the
misc/re-export-config
branch
from
34323ec to
eb83db7
Compare
peaBerberian
force-pushed
the
misc/config-compat
branch
from
e353d59 to
d092bb2
Compare
peaBerberian
force-pushed
the
misc/re-export-config
branch
from
eb83db7 to
65260a2
Compare
peaBerberian
force-pushed
the
misc/config-compat
branch
from
d092bb2 to
8148d71
Compare
peaBerberian
force-pushed
the
misc/re-export-config
branch
from
65260a2 to
896f58e
Compare
peaBerberian
force-pushed
the
misc/config-compat
branch
from
8148d71 to
b7e5d4b
Compare
peaBerberian
force-pushed
the
misc/config-compat
branch
from
b7e5d4b to
dbf1fd4
Compare
peaBerberian
force-pushed
the
misc/config-compat
branch
from
dbf1fd4 to
e8a1824
Compare
Based on #1510, the idea behind this proposal is to add to our config properties allowing to force toggles we for now only enable for specific devices. The goal is to simplify the debugging of issues seen on specific devices (which is the huge majority of them), by just having to update the config in the corresponding application (as proposed by #1510). So for example let's say that we encounter a new device where relying on the same `MediaKeys` instance for multiple contents may fail after a time (bug encountered on LG's WebOS, on some Panasonic TVs, and now, in issue #1464, on Philips's TitanOS), we could just initially tell application people to try setting that experimental flag. If it fixes the issue, we will add a supplementary device check inside the corresponding compat function. This seems faster and less bothersome to me than having to create special builds of the RxPlayer, and there our role could just be to redirect the developer seeing the issue to the right config option (as opposed to having to build a player, then link that player to the application, making sure that their CI like us etc.).
peaBerberian
force-pushed
the
misc/config-compat
branch
from
e8a1824 to
9d35b2c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #1510, the idea behind this proposal is to add to our config properties allowing to force toggles we for now only enable for specific devices.
The goal is to simplify the debugging of issues seen on specific devices (which is the huge majority of them), by just having to update the config in the corresponding application (as proposed by #1510).
So for example let's say that we encounter a new device where relying on the same
MediaKeysinstance for multiple contents may fail after a time (bug encountered on LG's WebOS, on some Panasonic TVs, and now, in issue #1464, on Philips's TitanOS), we could just initially tell application people to try setting that experimental flag.If it fixes the issue, we will add a supplementary device check inside the corresponding compat function.
This seems faster and less bothersome to me than having to create special builds of the RxPlayer, and there our role could just be to redirect the developer seeing the issue to the right config option (as opposed to having to build a player, then link that player to the application, making sure that their CI like us etc.).