Support Panasonic 2019 TVs #1226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peaBerberian
added
Compatibility
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An issue, #1219, noticed several problems preventing from playing encrypted content on Panasonic 2019 TVs:
Though it advertises for widevine L1 support, it does not support any {video,audio}Capabilities' robustness.
To fix this, I chose to re-bring the legacy work-around of adding a supplementary MediaKeySystemConfiguration without any {audio,video}Capabilities
Playing multiple encrypted contents through the same RxPlayer instance causes playback issues.
This seems similar to issue we have on LG TVs. The work-around of re-doing EME negotiation from MediaKeys creation for each content also works here.
To implement the second work-around, I updated the browser detection code (using an IIFE). To detect Panasonic devices, I've been voluntarily large - only spotting a "panasonic" substring in the user-agent.