-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bring various v4 recent improvements to next v3 version #1197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r disappear from the Manifest for the current Period
…ls terminating callbacks multiple times
peaBerberian
added
the
skip-performance-checks
Performance tests are not run on this PR
label
Jan 6, 2023
peaBerberian
added a commit
that referenced
this pull request
Jan 31, 2023
…ovements Bring various v4 recent improvements to next v3 version
peaBerberian
added a commit
that referenced
this pull request
Feb 8, 2023
…ovements Bring various v4 recent improvements to next v3 version
peaBerberian
added a commit
that referenced
this pull request
Feb 9, 2023
…ovements Bring various v4 recent improvements to next v3 version
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I worked a lot on our
next-v4
branch recently which is the branch for our next v4 major versions.Some work I have recently done on that branch can also be upstreamed to the v3 releases.
This branch thus adds:
For example previously, if the application stopped the content during a
availableAudioTracksChange
event, it was possible to still receive anavailableTextTracksChange
event after it.available...TracksChange
events in the very unlikely scenario where tracks are added after a manifest update (for the same Period for DASH, MetaPlaylist and local contents)RepresentationStream
guard, I'm unsure if this has an effect for the v3 but it is still a safety check.