DASH: Now handle endNumber DASH attribute
#1186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds handling of the `endNumber` attribute found on some DASH contents, which is the number the last segment should have. We decided to add it after seeing it used in the wild, most notably by some of Canal+ partners. This attribute is only present in newer 2019+ DASH specifications we funnily enough did not have access to until now. It was not in the latest DASH-IF specification neither.
peaBerberian
force-pushed
the
feat/endnumber
branch
from
6ecb32a to
a5dac78
Compare
peaBerberian
force-pushed
the
feat/endnumber
branch
from
a5dac78 to
b90839e
Compare
peaBerberian
force-pushed
the
feat/endnumber
branch
3 times, most recently
from
b339974 to
65eb57c
Compare
peaBerberian
force-pushed
the
feat/endnumber
branch
from
65eb57c to
19831c5
Compare
peaBerberian
added a commit
that referenced
this pull request
Dec 8, 2022
DASH: Now handle `endNumber` DASH attribute
peaBerberian
added a commit
that referenced
this pull request
Dec 15, 2022
DASH: Now handle `endNumber` DASH attribute
peaBerberian
added a commit
that referenced
this pull request
Dec 21, 2022
DASH: Now handle `endNumber` DASH attribute
peaBerberian
added a commit
that referenced
this pull request
Jan 31, 2023
DASH: Now handle `endNumber` DASH attribute
peaBerberian
added a commit
that referenced
this pull request
Feb 8, 2023
DASH: Now handle `endNumber` DASH attribute
peaBerberian
added a commit
that referenced
this pull request
Feb 9, 2023
DASH: Now handle `endNumber` DASH attribute
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds handling of the
endNumberattribute found on some DASH contents, which is the number the last segment should have.We decided to add it after seeing it used in the wild, most notably by some of Canal+ partners.
Without it, there might be issues if the duration announced on the corresponding Period or MPD lead the RxPlayer to believe that there's one more segment that there actually is.
This attribute is only present in newer 2019+ DASH specifications we funnily enough did not have access to until now. It was not in the latest DASH-IF specification neither.
The
endNumberattribute creates however an ambiguity: What should we do if a<SegmentTimeline>declares$Number$-based segments which should be impossible underendNumberrules? For now, I chose to rely on the highest constraints: whichever lead to the less segments.