Re-create MediaKeys at each loadVideo on WebOS #1175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peaBerberian
added
bug
We noticed of an issue on WebOS (LG TV) 2021 and 2022 models where loading an already-loaded encrypted content would not succeed: it would load indefinitely. After investigation, nothing in the JavaScript code seemed to go wrong, licences were loaded, but nothing was playing. However, we found out that re-creating the `MediaKeys` instance at each zap completely fixed the issue, with the cost of potential longer loading time (not measured yet). This seems to be definitely an issue linked to LG's software and we will share to them what we found, but we still chose to preemptively do a work-around specifically for WebOS 2021 and 2022 models so it works even know. If the issue become fixed in the future, we may remove that work-around. The major part of this commit are added tests on the code handling content decryption, to ensure that a MediaKeys is only re-created in some very specific cases (and keep being re-created in those).
peaBerberian
force-pushed
the
fix/lg-rezap-doesnt-work
branch
from
55e75cb to
e021232
Compare
Merged
peaBerberian
added a commit
that referenced
this pull request
Nov 30, 2022
In the last release, we added a work-around a WebOS (LG TVs) issue [#1175] where playing multiple times the same encrypted content could lead to infinite rebuffering. We thought at the beginning that the issue was only reproducible on WebOS for 2021 and 2022 TV models. However, we recently reproduced it on a WebOS 2019 TV, only on different contents - weirdly (the contents triggering the issue on more recent TV are different from the one triggering it on older ones). We're in the process of exchanging with LG on those find but for now, I chose to just activate the work-around, which may lead to higher loading time on LG TV, to all kinds of LG TVs.
peaBerberian
added a commit
that referenced
this pull request
Dec 1, 2022
In the last release, we added a work-around a WebOS (LG TVs) issue [#1175] where playing multiple times the same encrypted content could lead to infinite rebuffering. We thought at the beginning that the issue was only reproducible on WebOS for 2021 and 2022 TV models. However, we recently reproduced it on a WebOS 2019 TV, only on different contents - weirdly (the contents triggering the issue on more recent TV are different from the one triggering it on older ones). We're in the process of exchanging with LG on those find but for now, I chose to just activate the work-around, which may lead to higher loading time on LG TV, to all kinds of LG TVs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We noticed of an issue on WebOS (LG TV) 2021 and 2022 models where loading an already-loaded encrypted content would not succeed: it would load indefinitely.
After investigation, nothing in the JavaScript code seemed to go wrong, licences were loaded, but nothing was playing.
However, we found out that re-creating the
MediaKeysinstance at each zap completely fixed the issue, with the cost of potential longer loading time (not measured yet).This seems to be an issue linked to LG's software and we will share to them what we found, but we still chose to preemptively do a work-around specifically for WebOS 2021 and 2022 models so it works even know.
If the issue become fixed in the future, we may remove that work-around.
The major part of this commit are added tests on the code handling content decryption, to ensure that a MediaKeys is only re-created in some very specific cases (and keep being re-created in those).