Remove RxJS from the SegmentBuffer and related code #1127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peaBerberian
added
Refacto
peaBerberian
force-pushed
the
misc/segment_buffer-no-rxjs
branch
from
47d9f63 to
51149c1
Compare
peaBerberian
added
Performance checks
peaBerberian
force-pushed
the
misc/segment_buffer-no-rxjs
branch
from
51149c1 to
e9301fc
Compare
peaBerberian
force-pushed
the
next
branch
2 times, most recently
from
d784283 to
675d062
Compare
peaBerberian
force-pushed
the
misc/segment_buffer-no-rxjs
branch
from
e9301fc to
1cd2b42
Compare
peaBerberian
force-pushed
the
misc/segment_buffer-no-rxjs
branch
from
1cd2b42 to
c581e7a
Compare
peaBerberian
added
Performance checks
peaBerberian
added a commit
that referenced
this pull request
Sep 9, 2022
Remove RxJS from the SegmentBuffer and related code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is yet another PR to remove RxJS from parts of the code to raise the RxPlayer's "approachability", after #962 (for the transports code), #1042 (the content decryption code) and #1091 (from the adaptive code).
This time, this is the turn of a relatively smaller part of the code: the "SegmentBuffers (in
src/core/segment_buffers) which is the code wrapping browser's buffers (or even implementing them in the case of subtitles and image buffers).Like the other PR before it, this one makes heavy usage of:
ISharedReferenceobjects, which are very similar to RXJS BehaviorSubjects (always-set Observable values which are not lazy and can begetted at any time) to easily share values between blocks while allowing to trigger a callback when its inner state changes.TaskCancellerandCancellationSignal, which are very similar to respectively theAbortControllerandAbortSignalAPIs and which allows to easily and explicitly (generally unlike RxJS Observables where it often happens as a side-effect of unsubscription) abort cancellable asynchronous operations.