Avoid warning logs when "creating" segments #1049
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A small oversight led to the RxPlayer potentially logging a warning each time a segment is either created directly from the Manifest's information - which as far as I remember - only happens in Smooth contents or when no initialization segment exist (such as for subtitles). Aside from this unnecessary warning, there should be no other real issue. This warning was due to the fact that we're anouncing the end of those initialization's "requests" (between quotes as there there is in fact no request happening) two times in a row, breaking an assertion later in the code that ended request should be pending in the first place. It's annoying that I saw that just after finalizing the release, but thankfully this is a very minor issue that will probably not bother anyone, and should appear relatively rarely for DASH contents (maybe once when switching to a track with subtitles? Even this is unsure).
peaBerberian
force-pushed
the
fix/assertion-CI-issue
branch
from
57939fb to
2d44cc7
Compare
peaBerberian
changed the title
peaBerberian
changed the title
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A small oversight led to the RxPlayer potentially logging a warning each time a segment is either created directly from the Manifest's information - which as far as I remember - only happens in Smooth contents or when no initialization segment exist (such as for subtitles).
Aside from this unnecessary warning, there should be no other real issue.
This warning was due to the fact that we're announcing the end of those segment's "requests" (between quotes as there there is in fact no request happening) two times in a row, breaking an assertion later in the code that ended request should be pending in the first place.
It's annoying that I saw that just after finalizing the release, but thankfully this is a very minor issue that will probably not bother
anyone, and should appear relatively rarely for DASH contents (maybe once when switching to a track with subtitles? Even this is unsure).