-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add maxVideoBufferSize
option to limit the amount of video data (in kilobytes?) the RxPlayer will push on low-end devices
#1041
Conversation
Because one In any case, I'm wondering if that buffer size setting would not be better per-type: especially one for audio and one for video. |
Can you also rebase on master so the new GitHub actions are run? |
Almost done.
|
I also updated the base branch to |
When adding documentation files, you have also to update the Without it, the corresponding page won't be converted into HTML. |
fc25c86
to
775d48c
Compare
@@ -19,7 +19,7 @@ this job instead. | |||
|
|||
<div class="warning"> | |||
This option will have no effects if we didn't buffer at least <b>MIN_BUFFER_LENGTH</b> | |||
<i>( defaults at 5sec )</i> | |||
<i>( defaults at 5sec )</i>. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we shouldn't expose the name of our internal variable for two reasons:
- it might confuse the user
- it might change at any new version, without us thinking to update that part of the documentation
Needs to be rebased on |
No description provided.